<html>
<head><meta charset="utf-8"><title>Semantic Highlighting · t-compiler/rust-analyzer · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/index.html">t-compiler/rust-analyzer</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Semantic.20Highlighting.html">Semantic Highlighting</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="166353819"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Semantic%20Highlighting/near/166353819" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pascal <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Semantic.20Highlighting.html#166353819">(May 23 2019 at 12:02)</a>:</h4>
<p>hey, i wanted to look into semantic highlighting a bit (just because i was curious). i assume i'll need to get some kind of resolved identifiers map? building on the code from <a href="https://github.com/rust-analyzer/rust-analyzer/pull/1305" target="_blank" title="https://github.com/rust-analyzer/rust-analyzer/pull/1305">https://github.com/rust-analyzer/rust-analyzer/pull/1305</a> all i can get for bindings is that their kind is <code>MACRO_CALL</code>. what am I missing? :)</p>



<a name="166353926"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Semantic%20Highlighting/near/166353926" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Laurențiu <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Semantic.20Highlighting.html#166353926">(May 23 2019 at 12:04)</a>:</h4>
<p>See <a href="https://github.com/rust-analyzer/rust-analyzer/pull/1305/files#diff-7bd880cade5b808a957f2da2c32f6ecdR52" target="_blank" title="https://github.com/rust-analyzer/rust-analyzer/pull/1305/files#diff-7bd880cade5b808a957f2da2c32f6ecdR52">https://github.com/rust-analyzer/rust-analyzer/pull/1305/files#diff-7bd880cade5b808a957f2da2c32f6ecdR52</a></p>



<a name="166353931"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Semantic%20Highlighting/near/166353931" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Laurențiu <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Semantic.20Highlighting.html#166353931">(May 23 2019 at 12:04)</a>:</h4>
<p>You should get a reference to the macro definition</p>



<a name="166353948"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Semantic%20Highlighting/near/166353948" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matklad <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Semantic.20Highlighting.html#166353948">(May 23 2019 at 12:04)</a>:</h4>
<p>Hm, why macro calls?</p>



<a name="166353959"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Semantic%20Highlighting/near/166353959" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matklad <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Semantic.20Highlighting.html#166353959">(May 23 2019 at 12:05)</a>:</h4>
<p>I think you should check this variant: <a href="https://github.com/rust-analyzer/rust-analyzer/pull/1311/files#diff-6a30d8b895db7e4b6fba39666fe0aaabR13" target="_blank" title="https://github.com/rust-analyzer/rust-analyzer/pull/1311/files#diff-6a30d8b895db7e4b6fba39666fe0aaabR13">https://github.com/rust-analyzer/rust-analyzer/pull/1311/files#diff-6a30d8b895db7e4b6fba39666fe0aaabR13</a></p>



<a name="166353995"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Semantic%20Highlighting/near/166353995" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matklad <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Semantic.20Highlighting.html#166353995">(May 23 2019 at 12:05)</a>:</h4>
<p>Basically, if two <code>AstPtr&lt;ast::Pat&gt;</code> are the same, that's the same binding, and you can color it in the same color</p>



<a name="166354010"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Semantic%20Highlighting/near/166354010" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matklad <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Semantic.20Highlighting.html#166354010">(May 23 2019 at 12:05)</a>:</h4>
<p>does this make sense?</p>



<a name="166354083"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Semantic%20Highlighting/near/166354083" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pascal <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Semantic.20Highlighting.html#166354083">(May 23 2019 at 12:06)</a>:</h4>
<p>re macros: I have no clue, I just wanted to know what node kind to match on so i added <code>format!("{:?}", node.kind())</code> and got <code>MACRO_CALL</code> <span aria-label="shrug" class="emoji emoji-1f937" role="img" title="shrug">:shrug:</span></p>



<a name="166354141"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Semantic%20Highlighting/near/166354141" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Laurențiu <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Semantic.20Highlighting.html#166354141">(May 23 2019 at 12:07)</a>:</h4>
<p>Don't look at <code>node.kind()</code>, look at the result of <code>classify_name_ref</code></p>



<a name="166354152"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Semantic%20Highlighting/near/166354152" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pascal <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Semantic.20Highlighting.html#166354152">(May 23 2019 at 12:07)</a>:</h4>
<p>ah, so you're saying it should be in the NAME_REF case as well?</p>



<a name="166354230"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Semantic%20Highlighting/near/166354230" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Laurențiu <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Semantic.20Highlighting.html#166354230">(May 23 2019 at 12:08)</a>:</h4>
<p><code>NAME_REF</code> is a reference to a ..symbol, including macros, but <code>node</code> doesn't contain that information</p>



<a name="166354235"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Semantic%20Highlighting/near/166354235" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Laurențiu <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Semantic.20Highlighting.html#166354235">(May 23 2019 at 12:08)</a>:</h4>
<p><code>NAME</code> is a symbol declaration (or definition)</p>



<a name="166354510"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Semantic%20Highlighting/near/166354510" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Laurențiu <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Semantic.20Highlighting.html#166354510">(May 23 2019 at 12:12)</a>:</h4>
<p>What <code>classify_name_ref</code> does is it takes a <code>NAME_REF</code> and gives you back the definition of that name, like a <code>MacroByExampleDef</code> for macros. That ends up wrapping an <code>AstId</code>, which could presumably be hashed or used otherwise to assign a color</p>



<a name="166354512"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Semantic%20Highlighting/near/166354512" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pascal <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Semantic.20Highlighting.html#166354512">(May 23 2019 at 12:12)</a>:</h4>
<p>i think i'm a bit confused how that <code>match node.kind()</code> works :D i'll play around with it a bit</p>



<a name="166354525"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Semantic%20Highlighting/near/166354525" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pascal <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Semantic.20Highlighting.html#166354525">(May 23 2019 at 12:12)</a>:</h4>
<p>thanks</p>



<a name="166354530"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Semantic%20Highlighting/near/166354530" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Laurențiu <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Semantic.20Highlighting.html#166354530">(May 23 2019 at 12:12)</a>:</h4>
<p>If you're using RA in VS Code, try the "Show Syntax Tree" command</p>



<a name="166354548"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Semantic%20Highlighting/near/166354548" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Laurențiu <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Semantic.20Highlighting.html#166354548">(May 23 2019 at 12:12)</a>:</h4>
<p><code>node</code> is just an AST node, without any semantic information</p>



<a name="166395197"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Semantic%20Highlighting/near/166395197" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pascal <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Semantic.20Highlighting.html#166395197">(May 23 2019 at 20:08)</a>:</h4>
<p>super trivial first version just to see if it's doable: <a href="https://github.com/rust-analyzer/rust-analyzer/pull/1319" target="_blank" title="https://github.com/rust-analyzer/rust-analyzer/pull/1319">https://github.com/rust-analyzer/rust-analyzer/pull/1319</a></p>



<a name="166523518"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Semantic%20Highlighting/near/166523518" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pascal <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Semantic.20Highlighting.html#166523518">(May 25 2019 at 11:34)</a>:</h4>
<p><span class="user-mention" data-user-id="133169">@matklad</span> hm, testing highlighting via html output will mean that for the rainbow stuff i'll need to figure out how best to get the color calc code in there. it depends on a seedable rng which is an external dependency but i might just inline it</p>



<a name="166523532"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Semantic%20Highlighting/near/166523532" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matklad <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Semantic.20Highlighting.html#166523532">(May 25 2019 at 11:35)</a>:</h4>
<p>For testing, you can only set the css class to hash, without adding any JS magic</p>



<a name="166523533"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Semantic%20Highlighting/near/166523533" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pascal <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Semantic.20Highlighting.html#166523533">(May 25 2019 at 11:35)</a>:</h4>
<p>nah, that's too boring</p>



<a name="166523647"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Semantic%20Highlighting/near/166523647" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matklad <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Semantic.20Highlighting.html#166523647">(May 25 2019 at 11:39)</a>:</h4>
<p>Hm, you can also generate <em>css</em> itself on the server-side <span aria-label="thinking" class="emoji emoji-1f914" role="img" title="thinking">:thinking:</span></p>



<a name="166523775"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Semantic%20Highlighting/near/166523775" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pascal <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Semantic.20Highlighting.html#166523775">(May 25 2019 at 11:42)</a>:</h4>
<p>good idea! that also makes implementing a <code>--rainbow</code> flag easier</p>



<a name="190193980"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Semantic%20Highlighting/near/190193980" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> std::Veetaha <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Semantic.20Highlighting.html#190193980">(Mar 10 2020 at 16:30)</a>:</h4>
<p><span class="user-mention" data-user-id="133169">@matklad</span> , <span class="user-mention" data-user-id="203366">@Jeremy Kolb</span> IIRC semantic highlighting landed to stable vscode 1.43 (at least Typescript langua server now has this enabled by default). Should we <strong>REMOVE CODE</strong> that implements old highlighting?</p>



<a name="190194128"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Semantic%20Highlighting/near/190194128" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matklad <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Semantic.20Highlighting.html#190194128">(Mar 10 2020 at 16:32)</a>:</h4>
<p>Yup!</p>



<a name="190194182"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Semantic%20Highlighting/near/190194182" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matklad <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Semantic.20Highlighting.html#190194182">(Mar 10 2020 at 16:32)</a>:</h4>
<p>Though we need to verify that they actually stabilized the prposed API...</p>



<a name="190194199"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Semantic%20Highlighting/near/190194199" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> std::Veetaha <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Semantic.20Highlighting.html#190194199">(Mar 10 2020 at 16:32)</a>:</h4>
<p>Triggered</p>



<a name="190194229"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Semantic%20Highlighting/near/190194229" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matklad <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Semantic.20Highlighting.html#190194229">(Mar 10 2020 at 16:32)</a>:</h4>
<p>Can't typescript plugin use more API than other plugins?</p>



<a name="190195141"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Semantic%20Highlighting/near/190195141" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> std::Veetaha <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Semantic.20Highlighting.html#190195141">(Mar 10 2020 at 16:41)</a>:</h4>
<p>I don't think so even Though typescript extension is bundled with vscode</p>



<a name="190196808"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Semantic%20Highlighting/near/190196808" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jeremy Kolb <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Semantic.20Highlighting.html#190196808">(Mar 10 2020 at 16:55)</a>:</h4>
<p>I tried this yesterday after bumping the engine version and it still failed. I believe semantic tokens is still proposed in vscode</p>



<a name="190197348"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Semantic%20Highlighting/near/190197348" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jeremy Kolb <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Semantic.20Highlighting.html#190197348">(Mar 10 2020 at 16:59)</a>:</h4>
<p>I believe that this iteration will see range support added so hopefully the feature will be stabilized</p>



<a name="190197792"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Semantic%20Highlighting/near/190197792" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> std::Veetaha <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Semantic.20Highlighting.html#190197792">(Mar 10 2020 at 17:03)</a>:</h4>
<p>Hmm, so TypeScript does have a Carte Blanche for using proposed APIs?</p>



<a name="190198757"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Semantic%20Highlighting/near/190198757" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jeremy Kolb <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Semantic.20Highlighting.html#190198757">(Mar 10 2020 at 17:10)</a>:</h4>
<p>I believe so because it's distributed as part of vscode</p>



<a name="190198874"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Semantic%20Highlighting/near/190198874" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jeremy Kolb <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Semantic.20Highlighting.html#190198874">(Mar 10 2020 at 17:12)</a>:</h4>
<p><span class="user-mention" data-user-id="258149">@std::Veetaha</span>  <a href="https://github.com/microsoft/vscode/tree/master/extensions/typescript-language-features" target="_blank" title="https://github.com/microsoft/vscode/tree/master/extensions/typescript-language-features">https://github.com/microsoft/vscode/tree/master/extensions/typescript-language-features</a></p>



<a name="190199254"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Semantic%20Highlighting/near/190199254" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matklad <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Semantic.20Highlighting.html#190199254">(Mar 10 2020 at 17:15)</a>:</h4>
<p><a href="https://github.com/microsoft/vscode/blob/4e605ec54a58213b2db2e0b2c2d19e17833a46bb/extensions/typescript-language-features/package.json#L11" target="_blank" title="https://github.com/microsoft/vscode/blob/4e605ec54a58213b2db2e0b2c2d19e17833a46bb/extensions/typescript-language-features/package.json#L11">https://github.com/microsoft/vscode/blob/4e605ec54a58213b2db2e0b2c2d19e17833a46bb/extensions/typescript-language-features/package.json#L11</a></p>



<a name="190200505"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Semantic%20Highlighting/near/190200505" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jeremy Kolb <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Semantic.20Highlighting.html#190200505">(Mar 10 2020 at 17:25)</a>:</h4>
<p>I think all of those extensions have it set</p>



<a name="190200727"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Semantic%20Highlighting/near/190200727" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jeremy Kolb <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Semantic.20Highlighting.html#190200727">(Mar 10 2020 at 17:27)</a>:</h4>
<p><a href="https://github.com/microsoft/vscode/blob/04c9b01affe9201c3c96533aba56639e810e940f/src/vs/workbench/contrib/welcome/common/viewsWelcomeContribution.ts#L43" target="_blank" title="https://github.com/microsoft/vscode/blob/04c9b01affe9201c3c96533aba56639e810e940f/src/vs/workbench/contrib/welcome/common/viewsWelcomeContribution.ts#L43">https://github.com/microsoft/vscode/blob/04c9b01affe9201c3c96533aba56639e810e940f/src/vs/workbench/contrib/welcome/common/viewsWelcomeContribution.ts#L43</a></p>



<a name="190200751"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Semantic%20Highlighting/near/190200751" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jeremy Kolb <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Semantic.20Highlighting.html#190200751">(Mar 10 2020 at 17:27)</a>:</h4>
<p>I think that's the check</p>



<a name="190613540"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Semantic%20Highlighting/near/190613540" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> std::Veetaha <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Semantic.20Highlighting.html#190613540">(Mar 14 2020 at 20:43)</a>:</h4>
<p><span class="user-mention" data-user-id="203366">@Jeremy Kolb</span> , is it necessary to start with <code>--enable-proposed-api matklad.rust-analyzer</code> even on  <code>code-insiders</code> ?</p>



<a name="190613906"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Semantic%20Highlighting/near/190613906" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matklad <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Semantic.20Highlighting.html#190613906">(Mar 14 2020 at 20:52)</a>:</h4>
<p>Yes</p>



<a name="190615069"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Semantic%20Highlighting/near/190615069" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> std::Veetaha <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Semantic.20Highlighting.html#190615069">(Mar 14 2020 at 21:24)</a>:</h4>
<p><code>self</code> is assigned a <code>keyword.control</code> token kind, I think this is a bug?</p>



<a name="190615072"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Semantic%20Highlighting/near/190615072" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> std::Veetaha <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Semantic.20Highlighting.html#190615072">(Mar 14 2020 at 21:24)</a>:</h4>
<p><a href="user_uploads/4715/C5d0cZv2_JOoS4biWedUb1cD/image.png" target="_blank" title="user_uploads/4715/C5d0cZv2_JOoS4biWedUb1cD/image.png">image.png</a></p>
<div class="message_inline_image"><a href="user_uploads/4715/C5d0cZv2_JOoS4biWedUb1cD/image.png" target="_blank" title="image.png"><img src="user_uploads/4715/C5d0cZv2_JOoS4biWedUb1cD/image.png"></a></div>



<a name="190640940"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Semantic%20Highlighting/near/190640940" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matklad <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Semantic.20Highlighting.html#190640940">(Mar 15 2020 at 10:32)</a>:</h4>
<p>I think it's a bug in the visualisation, compare the output for <code>if</code> and <code>self</code></p>



<a name="190783943"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Semantic%20Highlighting/near/190783943" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> std::Veetaha <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Semantic.20Highlighting.html#190783943">(Mar 16 2020 at 21:45)</a>:</h4>
<p>Hey guys, is there a way to create a separate semantic tokens color customization rules for different languages? e.g. in typescript <code>member</code> with <code>delcaration</code> modifier is a method declaration (but <code>property</code> with <code>declaration</code> is for property declarations). But in Rust we use <code>member</code> with <code>declaration</code> modifier as property declaration and these conflict in my eyes ...</p>



<a name="190784407"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Semantic%20Highlighting/near/190784407" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matklad <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Semantic.20Highlighting.html#190784407">(Mar 16 2020 at 21:50)</a>:</h4>
<p>Good question. I think, in the conv layer, we should add “rust” modifier to<br>
all tokens.</p>



<a name="190786912"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Semantic%20Highlighting/near/190786912" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> std::Veetaha <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Semantic.20Highlighting.html#190786912">(Mar 16 2020 at 22:16)</a>:</h4>
<p>Hmm, there is none as per vscode <code>inspect</code> tool: <br>
<a href="/user_uploads/4715/Q3pC9XZVig_29hXjv1e-Ozoe/image.png" target="_blank" title="image.png">image.png</a></p>
<div class="message_inline_image"><a href="/user_uploads/4715/Q3pC9XZVig_29hXjv1e-Ozoe/image.png" target="_blank" title="image.png"><img src="/user_uploads/4715/Q3pC9XZVig_29hXjv1e-Ozoe/image.png"></a></div>



<a name="190787207"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Semantic%20Highlighting/near/190787207" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> std::Veetaha <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Semantic.20Highlighting.html#190787207">(Mar 16 2020 at 22:19)</a>:</h4>
<p>There just is no way to express the intention for filtering particular languages in vscode's <code>editor.tokenColorCustomizationsExperimental</code> config</p>



<a name="190816960"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Semantic%20Highlighting/near/190816960" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matklad <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Semantic.20Highlighting.html#190816960">(Mar 17 2020 at 08:11)</a>:</h4>
<p>There's none because we <em>should</em> add that modifier, it's not there yet</p>



<a name="190827730"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Semantic%20Highlighting/near/190827730" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> std::Veetaha <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Semantic.20Highlighting.html#190827730">(Mar 17 2020 at 10:07)</a>:</h4>
<p>Ah, I just interpreded<code>should</code> as <code>already</code></p>



<a name="190837043"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Semantic%20Highlighting/near/190837043" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jeremy Kolb <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Semantic.20Highlighting.html#190837043">(Mar 17 2020 at 11:56)</a>:</h4>
<p>Isn't that what <a href="https://github.com/microsoft/vscode/wiki/Semantic-Highlighting-Overview#token-classification" target="_blank" title="https://github.com/microsoft/vscode/wiki/Semantic-Highlighting-Overview#token-classification">https://github.com/microsoft/vscode/wiki/Semantic-Highlighting-Overview#token-classification</a> is for?</p>



<a name="190903344"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Semantic%20Highlighting/near/190903344" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> std::Veetaha <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Semantic.20Highlighting.html#190903344">(Mar 17 2020 at 20:01)</a>:</h4>
<p>There is no word about specifying the language name as a modifier, e.g. TypeScript doesn't add <code>typescript</code> modifier. I think this is a hole in the protocol. There must be some strictly-defined way to set the language of the token (taking into account quasi quotation this has to be on the token level)</p>



<a name="190925372"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Semantic%20Highlighting/near/190925372" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jeremy Kolb <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Semantic.20Highlighting.html#190925372">(Mar 17 2020 at 23:44)</a>:</h4>
<p>Hm. The semantic highlighting setting can be controlled by language (that is explicitly called out). I think they infer the language based on the provider or whatever</p>



<a name="190925499"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Semantic%20Highlighting/near/190925499" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jeremy Kolb <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Semantic.20Highlighting.html#190925499">(Mar 17 2020 at 23:46)</a>:</h4>
<p>Somewhere I read that the <code>editor.semanticHighlighting.enabled</code> setting can become <code>lang.semanticHighlighting.enabled</code></p>



<a name="190925648"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Semantic%20Highlighting/near/190925648" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jeremy Kolb <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Semantic.20Highlighting.html#190925648">(Mar 17 2020 at 23:49)</a>:</h4>
<p>doesn't answer your question though...</p>



<a name="190925687"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Semantic%20Highlighting/near/190925687" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jeremy Kolb <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Semantic.20Highlighting.html#190925687">(Mar 17 2020 at 23:49)</a>:</h4>
<p>you may want to open an issue in the vscode-languageclient repo</p>



<a name="191889099"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Semantic%20Highlighting/near/191889099" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jeremy Kolb <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Semantic.20Highlighting.html#191889099">(Mar 26 2020 at 14:06)</a>:</h4>
<p>This was just merged into vscode: <a href="https://github.com/microsoft/vscode/pull/93378" title="https://github.com/microsoft/vscode/pull/93378">https://github.com/microsoft/vscode/pull/93378</a></p>



<a name="191889163"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Semantic%20Highlighting/near/191889163" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jeremy Kolb <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Semantic.20Highlighting.html#191889163">(Mar 26 2020 at 14:07)</a>:</h4>
<p>I think that may address the per language concern?</p>



<a name="191889179"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Semantic%20Highlighting/near/191889179" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jeremy Kolb <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Semantic.20Highlighting.html#191889179">(Mar 26 2020 at 14:07)</a>:</h4>
<p>Sorry I have 0 time to work on anything lately</p>



<a name="191932319"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Semantic%20Highlighting/near/191932319" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> std::Veetaha <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Semantic.20Highlighting.html#191932319">(Mar 26 2020 at 18:53)</a>:</h4>
<p>Thanks, Jeremy, this is what I wanted</p>



<a name="195021424"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Semantic%20Highlighting/near/195021424" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Laurențiu <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Semantic.20Highlighting.html#195021424">(Apr 23 2020 at 06:06)</a>:</h4>
<p>Is this normal? Why are there scopes for so many languages?</p>
<p><a href="/user_uploads/4715/YrvHLlicB2_SLTUCt9geTCTF/image.png" title="image.png">image.png</a> </p>
<div class="message_inline_image"><a href="/user_uploads/4715/YrvHLlicB2_SLTUCt9geTCTF/image.png" title="image.png"><img src="/user_uploads/4715/YrvHLlicB2_SLTUCt9geTCTF/image.png"></a></div><p><a href="/user_uploads/4715/8xAv9tZwLoDxqL_xe_evNwIh/image.png" title="image.png">image.png</a></p>
<div class="message_inline_image"><a href="/user_uploads/4715/8xAv9tZwLoDxqL_xe_evNwIh/image.png" title="image.png"><img src="/user_uploads/4715/8xAv9tZwLoDxqL_xe_evNwIh/image.png"></a></div>



<a name="195030829"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Semantic%20Highlighting/near/195030829" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matklad <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Semantic.20Highlighting.html#195030829">(Apr 23 2020 at 08:25)</a>:</h4>
<p>Bad UI</p>



<a name="195030846"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Semantic%20Highlighting/near/195030846" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matklad <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Semantic.20Highlighting.html#195030846">(Apr 23 2020 at 08:25)</a>:</h4>
<p>This is the header of the rule which matches the scope</p>



<a name="195030945"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Semantic%20Highlighting/near/195030945" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matklad <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Semantic.20Highlighting.html#195030945">(Apr 23 2020 at 08:26)</a>:</h4>
<p>IE, this is a rule from the color theme, and, among the N things there, there's one that matches default mapping of semantic tokens to textmate scopes</p>



<a name="195033820"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Semantic%20Highlighting/near/195033820" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Laurențiu <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Semantic.20Highlighting.html#195033820">(Apr 23 2020 at 08:59)</a>:</h4>
<p>Ah, it's CSS</p>



<a name="195041817"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Semantic%20Highlighting/near/195041817" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> apiraino <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Semantic.20Highlighting.html#195041817">(Apr 23 2020 at 10:24)</a>:</h4>
<p><span class="user-mention silent" data-user-id="203546">Laurențiu Nicola</span> <a href="#narrow/stream/185405-t-compiler.2Fwg-rls-2.2E0/topic/semantic.20highlighting/near/195033820" title="#narrow/stream/185405-t-compiler.2Fwg-rls-2.2E0/topic/semantic.20highlighting/near/195033820">said</a>:</p>
<blockquote>
<p>Ah, it's CSS</p>
</blockquote>
<p>still funny, imo :-)</p>



<a name="225478274"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Semantic%20Highlighting/near/225478274" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Martin Asquino <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Semantic.20Highlighting.html#225478274">(Feb 07 2021 at 18:59)</a>:</h4>
<p>Hi folks, just checking if my understand is correct here. Am I correct to say that semantic highlighting (former) proposal in LSP has been replaced by semantic tokens? And also, that the server no longer sends semantic highlighting scopes?</p>



<a name="225517960"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Semantic%20Highlighting/near/225517960" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matklad <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Semantic.20Highlighting.html#225517960">(Feb 08 2021 at 09:14)</a>:</h4>
<p>Yep, bothe the old lsp proposal, and the old highlighting infra in analyzer are removed.</p>



<a name="225518014"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Semantic%20Highlighting/near/225518014" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matklad <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Semantic.20Highlighting.html#225518014">(Feb 08 2021 at 09:15)</a>:</h4>
<p>To clear some potential confusion, we never implemented the old lsp proposal, we did our own thing.</p>



<a name="225523228"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Semantic%20Highlighting/near/225523228" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Martin Asquino <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Semantic.20Highlighting.html#225523228">(Feb 08 2021 at 10:09)</a>:</h4>
<p>ah fair enough, I'll see to update the client so it supports semantic tokens then, thank you <span aria-label="+1" class="emoji emoji-1f44d" role="img" title="+1">:+1:</span></p>



<a name="225546158"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Semantic%20Highlighting/near/225546158" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jeremy Kolb <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Semantic.20Highlighting.html#225546158">(Feb 08 2021 at 13:49)</a>:</h4>
<p>I also removed it from the <code>lsp-types</code> crate.</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>